-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scroll bubbling monkeypatches #71
Conversation
spec.bs
Outdated
|
||
Modify the [=run the scroll steps=] algorithm to add a check after step 1.1 that reads: | ||
|
||
2. If <var ignore=''>target</var> is a {{Document}} whose [=node navigable=]'s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches the impl behavior that doesn't propagate scroll events into a fenced frame. Is this the expected behavior? I wrote this just to match what we currently have in impl, but if this isn't what the behavior is supposed to be, we should file a crbug to fix.
Could you resolve the conflicts on this PR? |
The wrapping on this PR seems pretty off. Could you fix it? |
Formatting is still off :( please check your work |
I got Rewrap working with the spec file, so hopefully the formatting issues shouldn't happen again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the fixes I've made in the last commit so that you do not make them again.
container/fenced navigable=], then let this be the last instance of this algorithm that stops | ||
any further recursive instances that would otherwise follow. | ||
|
||
Note: This allows scrolling to "bubble up" to a fenced frame boundary, but not cross it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh one more thing, do we have any tests that we can point to here in a <wpt>
block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, no. But we have an item in the fenced frame tracker to migrate the browsertests over to WPTs.
SHA: eb6b50e Reason: push, by blu25 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Preview | Diff